Skip to content

Conversation

ppedrot
Copy link
Member

@ppedrot ppedrot commented Jan 15, 2025

This data does not belong semantically here. Instead, it should be derived from the context, as it is alway in sync with the name through which the module was added to the environment.

Depends on: #20058

Backwards compatible overlays:

@ppedrot ppedrot added kind: cleanup Code removal, deprecation, refactorings, etc. needs: merge of dependency This PR depends on another PR being merged first. request: full CI Use this label when you want your next push to trigger a full CI. labels Jan 15, 2025
@ppedrot ppedrot added this to the 9.1+rc1 milestone Jan 15, 2025
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Jan 15, 2025
ppedrot added a commit to ppedrot/coq-elpi that referenced this pull request Jan 15, 2025
ppedrot added a commit to ppedrot/paramcoq that referenced this pull request Jan 15, 2025
ppedrot added a commit to ppedrot/coq-elpi that referenced this pull request Jan 15, 2025
ppedrot added a commit to ppedrot/metarocq that referenced this pull request Jan 15, 2025
ppedrot added a commit to rocq-community/paramcoq that referenced this pull request Jan 15, 2025
ppedrot added a commit to MetaRocq/metarocq that referenced this pull request Jan 15, 2025
gares added a commit to LPCIC/coq-elpi that referenced this pull request Jan 15, 2025
This data does not belong semantically here. Instead, it should be derived
from the context, as it is alway in sync with the name through which the
module was added to the environment.
@ppedrot ppedrot added the request: full CI Use this label when you want your next push to trigger a full CI. label Jan 15, 2025
@ppedrot ppedrot force-pushed the module-remove-modpath branch from 0a2ef0d to 3eabc97 Compare January 15, 2025 20:53
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Jan 15, 2025
@ppedrot ppedrot marked this pull request as ready for review January 15, 2025 20:53
@ppedrot ppedrot requested review from a team as code owners January 15, 2025 20:53
@ppedrot ppedrot removed the needs: merge of dependency This PR depends on another PR being merged first. label Jan 15, 2025
@SkySkimmer SkySkimmer self-assigned this Jan 16, 2025
@SkySkimmer
Copy link
Contributor

@coqbot merge now

@coqbot-app coqbot-app bot merged commit 7d4ec9e into rocq-prover:master Jan 16, 2025
5 of 6 checks passed
@ppedrot ppedrot deleted the module-remove-modpath branch January 16, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: cleanup Code removal, deprecation, refactorings, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants