Skip to content

Conversation

yannl35133
Copy link
Contributor

@yannl35133 yannl35133 commented Jun 27, 2024

  • Added / updated test-suite.
  • Added changelog.
  • Added / updated documentation.
    • Documented any new / changed user messages.
    • Updated documented syntax by running make doc_gram_rsts.
  • Opened overlay pull requests.

@coqbot-app coqbot-app bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Jun 27, 2024
@coqbot-app coqbot-app bot added needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. and removed needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. labels Jul 26, 2024
@yannl35133 yannl35133 marked this pull request as ready for review July 26, 2024 12:59
@yannl35133 yannl35133 requested review from a team as code owners July 26, 2024 12:59
@yannl35133
Copy link
Contributor Author

It remains to be decided of what to do when the rule breaks SR: right now, coqc emits a warning but coqchk fails (hence the test failures)

@yannl35133 yannl35133 requested a review from a team as a code owner July 26, 2024 13:36
@github-actions github-actions bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Jul 30, 2024
Copy link
Contributor

coqbot-app bot commented Aug 29, 2024

The "needs: rebase" label was set more than 30 days ago. If the PR is not rebased in 30 days, it will be automatically closed.

@coqbot-app coqbot-app bot added the stale This PR will be closed unless it is rebased. label Aug 29, 2024
@coqbot-app coqbot-app bot removed needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. stale This PR will be closed unless it is rebased. labels Sep 5, 2024
@github-actions github-actions bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Sep 10, 2024
@coqbot-app coqbot-app bot removed the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Sep 17, 2024
@github-actions github-actions bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Jan 16, 2025
@coqbot-app coqbot-app bot removed the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Jan 27, 2025
@github-actions github-actions bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Jan 27, 2025
Copy link
Contributor

coqbot-app bot commented Feb 26, 2025

The "needs: rebase" label was set more than 30 days ago. If the PR is not rebased in 30 days, it will be automatically closed.

@coqbot-app coqbot-app bot added the stale This PR will be closed unless it is rebased. label Feb 26, 2025
@yannl35133 yannl35133 marked this pull request as draft March 5, 2025 18:22
@yannl35133 yannl35133 added the needs: merge of dependency This PR depends on another PR being merged first. label Mar 21, 2025
@coqbot-app coqbot-app bot removed needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. stale This PR will be closed unless it is rebased. labels Jul 18, 2025
@yannl35133
Copy link
Contributor Author

@ppedrot The changes I introduce in commit 9adea52 conflict with your overwrite_structure function (environ.ml). I don't know how to solve them best, can you please take a look?
Basically, I introduce a new syntax for rewrite rules, which contains the same kind of information as constant_body. However, reduction machines still use the old machine_rewrite_rule syntax, so a translation is required. This translation requires an environment, and is required in your function.

@github-actions github-actions bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Sep 1, 2025
@coqbot-app coqbot-app bot removed the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Sep 10, 2025
@yannl35133 yannl35133 removed the needs: merge of dependency This PR depends on another PR being merged first. label Sep 10, 2025
@yannl35133 yannl35133 marked this pull request as ready for review September 10, 2025 10:23
@yannl35133
Copy link
Contributor Author

I marked the PR as open for review, even though it fails to compile starting from commit 6.
The first 5 can be reviewed independently, they don't even talk of rewrite rules.
The 6th commit needs an answer from @ppedrot regarding his latest changes in environ.ml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: changelog entry This should be documented in doc/changelog. needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conversion incompleteness with Definitional UIP
2 participants