Formalization of result 46 and update of result 37 #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*New version of problem 37 (Cardan-Tartaglia formula) *New formalisation of problem 46 (Ferrari method for quartic equations.
Mentioned file changed (cardan_ferrari.v instead of cardan3.v).
Formalization of problems 37 and 46 (Cubic and quartic equations)
Replaced by cardan_ferrari.v
|
To make CI pass, please edit |
Replace cardan3.v by cardan_ferrari.v
Replace cardan3.v by cardan_ferrari.v. Mention that it also solves the quartic equation.
|
I have changed _CoqProject and README.md files accordingly. |
Fix a link to cardan_ferrari.html Change class attribute of "h3" to "formalized" for problem 46.
|
This looks good to me, I can merge unless @jmadiot has comments? |
|
Nice! @fredericchardard do you want me to change the date from "2017" to "2017-2020" in the .v's header license as well? (Or you can make a PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update of result 37 (cubic equation) and result 46 (quartic equation).
Both results are proved in the same file cardan_ferrari.v (hence cardan3.v is obsolete).
Changes are made accordingly in index.html and LICENSE files.