chore: add more info during teardown failures #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvmcastro
approved these changes
Jun 4, 2025
jhonasiv
approved these changes
Jun 4, 2025
Namely that it would show the list of tasks and/or quarantines only if that list changed, i.e. one might receive a warning listing only tasks while some quarantines are still there, if the quarantines were already shown the last message
doudou
force-pushed
the
more_teardown_info
branch
2 times, most recently
from
b15508e to
03dd97c
Compare
higor-melo
approved these changes
Jun 6, 2025
doudou
force-pushed
the
more_teardown_info
branch
from
03dd97c to
94c0eb0
Compare
This code was essentially incurring a 10ms penalty on all test teardowns
doudou
force-pushed
the
more_teardown_info
branch
from
19cca76 to
4d348f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.