ROB-2136 increase prometheus tool limit #1025
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. WalkthroughIntroduces ToolInvokeContext across core, tools, plugins, and tests; updates tool invocation signatures to use context; centralizes token-limit utilities; adds token-based counting and truncation for tool outputs; adjusts tool result formatting to include params; refactors Prometheus tools to token-based sizing and structured responses; updates tests accordingly. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant U as ToolCallingLLM
participant T as Tool
participant C as ToolInvokeContext
participant L as LLM
participant Lim as ContextWindowLimiter
participant Tok as TokenCounter
U->>U: get_max_token_count_for_single_tool(LLM)
U->>C: Build context (tool_number, user_approved, llm, max_token_count)
U->>T: invoke(params, context=C)
activate T
T->>T: _invoke(params, context) [tool-specific]
T-->>U: StructuredToolResult
deactivate T
U->>Tok: count_tool_response_tokens(LLM, result)
Tok-->>U: token_count
U->>Lim: prevent_overly_big_tool_response(result, LLM)
Lim-->>U: possibly adjusted result (ERROR if over limit)
U-->>U: format_tool_result_data(result) incl. Params used
U-->>U: as_tool_call_message(content=formatted)
sequenceDiagram
autonumber
participant P as PodLoggingTool
participant C as ToolInvokeContext
participant L as LLM
participant Tr as truncate_logs
P->>P: fetch logs (params)
P->>Tr: truncate_logs(result, L, C.max_token_count, params)
Tr->>L: count_tokens_for_message(...)
alt tokens > limit
Tr->>Tr: iterative truncation with prefix
Tr-->>P: shortened result
else
Tr-->>P: original result
end
P-->>Caller: StructuredToolResult
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (66)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.