Skip to content

Conversation

MGaetan89
Copy link
Member

This commit adds PR preview so its easier to see new changes and validate them.

Copy link

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@MGaetan89 MGaetan89 marked this pull request as draft September 12, 2025 09:36
@MGaetan89 MGaetan89 force-pushed the add-pr-preview branch 2 times, most recently from 8c536ed to f266f13 Compare September 13, 2025 14:15
This commit adds PR preview so its easier to see new changes and validate them.
@MGaetan89
Copy link
Member Author

The rossjrw/pr-preview-action action does not work for PR created from forks:

This Action does not currently support deploying previews for PRs from forks, but will do so in the upcoming v2.

This change will at least help us validate PRs from Renovate.

@MGaetan89 MGaetan89 marked this pull request as ready for review September 13, 2025 14:19
@MGaetan89 MGaetan89 self-assigned this Sep 13, 2025
@utzcoz
Copy link
Member

utzcoz commented Sep 14, 2025

Where will it deploy for preview?

@MGaetan89
Copy link
Member Author

Each non-fork PR (support for forks will come in a future version of the action) is deployed in the pr-preview/pr-<number> folder in the gh-pages branch.
A comment will be added on each supported PR with a link to the preview.
Once the PR is merged, the folder is deleted.

@utzcoz
Copy link
Member

utzcoz commented Sep 14, 2025

Sounds good. LTGM.

@MGaetan89 MGaetan89 merged commit d5ef1ba into robolectric:main Sep 14, 2025
2 checks passed
@MGaetan89 MGaetan89 deleted the add-pr-preview branch September 14, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants