Skip to content
This repository was archived by the owner on Feb 4, 2022. It is now read-only.

Fixed compatibility with shvl >= 1.3.0 #132

Merged
merged 1 commit into from
Apr 10, 2018

Conversation

qkdreyer
Copy link
Contributor

@qkdreyer qkdreyer commented Apr 9, 2018

Fixes #133

@qkdreyer
Copy link
Contributor Author

qkdreyer commented Apr 9, 2018

This is a breaking change, could you merge it ASAP please ?

@brianirish
Copy link

brianirish commented Apr 9, 2018

+1, broke my app this morning when I upgraded npm deps. Downgrading shvl down to 1.2.1 works as a workaround.

Temporary workaround to downgrade shvl:

rm -rf node_modules/shvl
npm i --no-save [email protected]

Note: The --no-save prevents shvl from being added as a dependency of your app. So, the next time you run npm install or npm upgrade, 1.2.1 will likely get replaced with 1.3.1 - or whatever is latest - and you'll have a broken app on your hands again.

The alternative is leaving out the --no-save and having shvl added as a dependency to your app. Then, whenever you run npm install, it won't overwrite with the latest version and your app won't break. Just remember to remove that dependency from your package.json file once this pull request gets merged.

@andrew-mark
Copy link

Can this be merged asap. thanks

@robinvdvleuten robinvdvleuten merged commit 9205b28 into robinvdvleuten:master Apr 10, 2018
@robinvdvleuten
Copy link
Owner

please see release v2.5.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants