Skip to content

Conversation

@itsmesrds
Copy link

Description

This PR adds a new function stream.take_events() which will return events()

#660 (Fixes #660)

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ sivasai-quartic
❌ itsmesrds
You have signed the CLA already but the status is still pending? Let us recheck it.

@fr-ser
Copy link
Contributor

fr-ser commented Oct 11, 2020

Since returning events is a requirement for manual acknowledgment, how about we include the "fix" for noack-streams as well?

I linked the bug in the feature request for this and here would be a code example of take with consideration for noack
https://gist.github.com/fr-ser/347c00e0026cd7941e1d73fd36e54887

@qbzenker
Copy link

qbzenker commented Jan 5, 2021

As a user of Faust, I would also like this PR to be approved/merged. The take_events functionality is super useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stream.take() function returns events() instead of values

6 participants