Skip to content

Fix 2280 by moving the bootstrap 3 classes out of SchemaField #4579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 29, 2025
Merged

Fix 2280 by moving the bootstrap 3 classes out of SchemaField #4579

merged 4 commits into from
Apr 29, 2025

Conversation

heath-freenome
Copy link
Member

@heath-freenome heath-freenome commented Apr 25, 2025 •
edited
Loading

Reasons for making this change

Fixed #2280 by moving marker classes from SchemaField to WrapIfAdditionalTemplate

  • In @rjsf/utils, updated WrapIfAdditionalTemplateProps to pick up the hideError and rawErrors props from FieldTemplateProps
  • In @rjsf/core, updated SchemaField to move the form-group class to the WrapIfAdditionalTemplate
    • Also moved the has-error and has-danger error classes
    • Updated the grid snapshot due to the change
    • Prefixed all rjsf marker classes with rjsf-
  • Updated the snapshots in other themes due to the removed marker classes
  • Updated the CHANGELOG_v6.md and v6x upgrade guide.md to reflect these changes

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@nickgros
Copy link
Contributor

@heath-freenome field is not actually a Bootstrap 3 class: https://bootstrapclasses.com/bootstrap-3-css-classes-index/

Should we keep the field class, and only remove form-group?

@heath-freenome
Fix 2280 by moving the bootstrap 3 marker classes out of SchemaField
10c6efd 
Fixed #2280 by moving marker classes from `SchemaField` to `WrapIfAdditionalTemplate`
- In `@rjsf/utils`, updated `WrapIfAdditionalTemplateProps` to pick up the `hideError` and `rawErrors` props from `FieldTemplateProps`
- In `@rjsf/core`, updated `SchemaField` to move the `form-group` and `field` marker classes to the `WrapIfAdditionalTemplate`
  - Also moved the `field-error`, `has-error` and `has-danger` error marker classes
  - Updated the grid snapshot due to the change
- Updated the snapshots in other themes due to the removed marker classes
- Updated the `CHANGELOG_v6.md` and `v6x upgrade guide.md` to reflect these changes
@heath-freenome
Copy link
Member Author

@heath-freenome field is not actually a Bootstrap 3 class: https://bootstrapclasses.com/bootstrap-3-css-classes-index/

Should we keep the field class, and only remove form-group?

@nickgros Hmmm, probably... I wonder if I should also keep the field-error marker class in SchemaField too?

@heath-freenome heath-freenome changed the title Fix 2280 by moving the bootstrap 3 marker classes out of SchemaField Fix 2280 by moving the bootstrap 3 classes out of SchemaField Apr 29, 2025
heath-freenome
heath-freenome commented Apr 29, 2025
View reviewed changes
packages/core/src/components/templates/ButtonTemplates/IconButton.tsx
icon='copy'
/>
);
return <IconButton title={translateString(TranslatableString.CopyButton)} {...props} icon='copy' />;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are added in the ArrayFieldItemButtonsTemplate