Add *.props and *.targets to XML section of .editorconfig template #240
Conversation
📝 WalkthroughWalkthroughThe changes include updates to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
rjmurillo
added
dependencies
|
Code Climate has analyzed commit b7b7312 and detected 0 issues on this pull request. View more on Code Climate. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range comments (1)
.editorconfig (1)
Line range hint
313-313: Fix incorrect type parameter symbol configuration.The type parameter symbol is incorrectly configured to apply to namespaces instead of type parameters. This could prevent proper enforcement of the
TPascalCasenaming convention for type parameters (e.g.,TinList<T>).Apply this fix:
-dotnet_naming_symbols.type_parameters.applicable_kinds = namespace +dotnet_naming_symbols.type_parameters.applicable_kinds = type_parameter
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (4)
- .editorconfig (1 hunks)
- Directory.Packages.props (1 hunks)
- src/CodeFixes/Moq.CodeFixes.csproj (1 hunks)
- tests/Moq.Analyzers.Test/Moq.Analyzers.Test.csproj (1 hunks)
🔇 Additional comments (4)
src/CodeFixes/Moq.CodeFixes.csproj (1)
4-6: LGTM! Consistent XML formatting applied.The indentation changes align with standard MSBuild practices and the PR's objective to standardize XML formatting. The 2-space indentation is consistently applied across both PropertyGroup and ItemGroup sections while preserving all functional aspects of the project file.
Also applies to: 10-10
tests/Moq.Analyzers.Test/Moq.Analyzers.Test.csproj (1)
32-32: LGTM! Adding newline at EOF.The addition of a newline character at the end of file follows standard text file best practices and aligns with common .editorconfig rules.
Directory.Packages.props (1)
36-36: LGTM! The newline addition follows best practices.Adding a newline at the end of the file is a good practice and aligns with common XML formatting standards.
Let's verify the XML formatting rules in .editorconfig:
✅ Verification successful
The newline addition is consistent with the codebase's XML formatting
While we couldn't find an explicit .editorconfig file, the XML files in the repository consistently follow proper formatting with newlines at the end. The change aligns with the existing XML files' structure and common best practices for text files.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify .editorconfig XML formatting rules # Expected: Should find rules for .props files with end_of_line settings rg -A 3 '^\[*.props\]|^\[*.xml\]' .editorconfigLength of output: 49
Script:
#!/bin/bash # Let's first check if .editorconfig exists and see its content fd -t f .editorconfig -x cat {} # As a backup, let's also check for any XML/props related configuration files fd -t f -e editorconfig -e props -e xml -e config --max-depth 2 -x cat {}Length of output: 4402
.editorconfig (1)
8-9: LGTM! XML section changes look good.The addition of
.propsand.targetsfiles to the XML section with 2-space indentation aligns with common XML formatting practices.
/cc @rjmurillo, this fixes some of the bot spam |
2 participants
Add *.props and *.targets to XML section of .editorconfig template and fix .editorconfig violations.
This also aligns our .editorconfig with the upcoming dotnet/sdk#44441.
Summary by CodeRabbit
.editorconfigto enhance formatting and naming conventions for XML and C# files.Directory.Packages.propsfile.Moq.CodeFixes.csprojfor better readability.Moq.Analyzers.Test.csprojfile.