Cache Rizin build directory in GitHub Actions workflow #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaiTon
force-pushed
the
cache-rizin
branch
4 times, most recently
from
01428a6 to
7edf257
Compare
wargio
requested changes
Jun 26, 2025
|
Why? Each time we rebuild the exact same thing. We're targeting a released version, not dev branch commits |
|
I know but I prefer to build each time. @ret2libc @notxvilka @Rot127 what do you guys think? |
|
Idk. Caching is nice. But I don't think we run this workflow often enough to justify the additional dependency. Or is this wrong? Just have seen I don't watch this repo. |
We run this workflow on each commit and in each PR, and the only dependency introduced is on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.