Skip to content

Conversation

@well-mannered-goat
Copy link
Contributor

@well-mannered-goat well-mannered-goat commented Jul 14, 2025

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).

Detailed description

  • removed a redundant file for linux arm64
  • have separated some functions which helps in understanding code since the native debugger code is #includeed into the debug_native.c
  • added a linux-s390x file for native plugin
  • added dwarf mapping for sysz architecture
  • added register progile for 64 bit s390x and fixed s390 32 bit. ( i have used all the registers that ptrace provides access to).
  • right now I just want to check if I am not breaking something

Please ignore the changes in .gitignore and meson.build, I have made those changes so that I can properly build and install to my VM. Hopefully disabling PCRE2 JIT doesnt break other sysz tests

Test plan

...

Closing issues

...

@Rot127
Copy link
Member

Rot127 commented Jul 21, 2025

Please move the non-s390x stuff into a separated PR after you are done here.

@well-mannered-goat well-mannered-goat force-pushed the dist-s390x_debug_support branch from e34c079 to 575b7bf Compare July 21, 2025 13:37
@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.64%. Comparing base (22089ed) to head (575b7bf).

Files with missing lines Patch % Lines
librz/arch/dwarf_process.c 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
librz/debug/p/native/linux/linux_debug.c 38.66% <ø> (ø)
librz/include/rz_types.h 30.76% <ø> (ø)
librz/arch/dwarf_process.c 61.26% <0.00%> (-0.09%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22089ed...575b7bf. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines -57 to +58
#elif __aarch64__
#include "native/linux_aarch64.c"
#elif __SYSZ__
#include "native/linux_s390x.c"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be an addition instead of a deletion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are two files

#elif __arm64__
#include "native/linux_arm64.c"
#elif __aarch64__
#include "native/linux_aarch64.c"

I found a redundant file

// return NULL;
// }
// return linux_thread_list(dbg, pid, list);
RZ_LOG_ERROR("Unsupport right now");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RZ_LOG_ERROR("Unsupport right now");
RZ_LOG_ERROR("Unsupported right now");

Copy link
Contributor

@notxvilka notxvilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants