-
-
Notifications
You must be signed in to change notification settings - Fork 442
Add s390x debug support and fix code in debug module #5267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
a765b71 to
caf2170
Compare
|
Please move the non-s390x stuff into a separated PR after you are done here. |
e34c079 to
575b7bf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| #elif __aarch64__ | ||
| #include "native/linux_aarch64.c" | ||
| #elif __SYSZ__ | ||
| #include "native/linux_s390x.c" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be an addition instead of a deletion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are two files
#elif __arm64__
#include "native/linux_arm64.c"
#elif __aarch64__
#include "native/linux_aarch64.c"
I found a redundant file
| // return NULL; | ||
| // } | ||
| // return linux_thread_list(dbg, pid, list); | ||
| RZ_LOG_ERROR("Unsupport right now"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| RZ_LOG_ERROR("Unsupport right now"); | |
| RZ_LOG_ERROR("Unsupported right now"); |
notxvilka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase and update
Your checklist for this pull request
RZ_APIfunction and struct this PR changes.RZ_API).Detailed description
#includeed into thedebug_native.cPlease ignore the changes in
.gitignoreandmeson.build, I have made those changes so that I can properly build and install to my VM. Hopefully disabling PCRE2 JIT doesnt break other sysz testsTest plan
...
Closing issues
...