Skip to content

Always upsert initial periodic job records #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025

Conversation

brandur
Copy link
Contributor

@brandur brandur commented Aug 3, 2025

Tweak the behavior for periodic job records inserted through the pilot
so that instead of being upserted the first time they're worked, upsert
them immediately on program start up, even if RunOnStart isn't
configured for them. This won't actually cause them to run, but will add
the durable record a little earlier than it would be before.

Tweak the behavior for periodic job records inserted through the pilot
so that instead of being upserted the first time they're worked, upsert
them immediately on program start up, even if `RunOnStart` isn't
configured for them. This won't actually cause them to run, but will add
the durable record a little earlier than it would be before.
@brandur brandur force-pushed the brandur-initial-periodic-job-records branch from 7f54c9c to 056f7d2 Compare August 3, 2025 19:05
@brandur brandur requested a review from bgentry August 3, 2025 19:12
Copy link
Contributor

@bgentry bgentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks like it was indeed fairly easy to fix, thank you 👏

@brandur
Copy link
Contributor Author

brandur commented Aug 6, 2025

Yeah, turned out to be surprisingly easy. Thanks!

@brandur brandur merged commit 5980899 into master Aug 6, 2025
10 checks passed
@brandur brandur deleted the brandur-initial-periodic-job-records branch August 6, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants