Always set updated_at when upserting periodic jobs
#1045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgentry
approved these changes
Sep 27, 2025
Contributor
bgentry
left a comment
bgentry
left a comment
There was a problem hiding this comment.
Ah, was gonna fix this on the pro query side but this is simpler!
Make sure to set `updated_at` when upserting periodic jobs on calls to the pilot's `PeriodicJobUpsert`. Not having `updated_at` was resulting in pilots with database backing to store zero values into their rows.
brandur
force-pushed
the
brandur-set-periodic-job-updated-at
branch
from
fa03453 to
eb8a48b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to set
updated_atwhen upserting periodic jobs on calls tothe pilot's
PeriodicJobUpsert. Not havingupdated_atwas resultingin pilots with database backing to store zero values into their rows.