Skip to content

match job kind and queue name by substring, not just prefix #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2025

Conversation

bgentry
Copy link
Contributor

@bgentry bgentry commented Aug 16, 2025

If you have long segmented job kinds, it's frustrating to have to type out a long shared prefix to get to the unique part.

There will be a matching riverui PR for this one too.

@bgentry bgentry requested a review from brandur August 16, 2025 04:24
If you have long segmented job kinds, it's frustrating to have to type
out a long shared prefix to get to the unique part.
@bgentry bgentry force-pushed the bg-filtering-by-midstring-match-not-only-prefix branch from ce1b4c0 to 2720d2d Compare August 16, 2025 04:33
Copy link
Contributor

@brandur brandur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@brandur
Copy link
Contributor

brandur commented Aug 16, 2025

Hm, maybe the CI matrix was working as I was expecting, and I was just getting confused by these phantom jobs. @bgentry How do you get rid of those again? Can we make it so they don't happen anymore?

@bgentry
Copy link
Contributor Author

bgentry commented Aug 16, 2025

@brandur just needed to update the branch protection rules, I think they're good now.

@bgentry bgentry merged commit 20287ed into master Aug 16, 2025
11 checks passed
@bgentry bgentry deleted the bg-filtering-by-midstring-match-not-only-prefix branch August 16, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants