Bring reduced batch size to all other standard maintenance services #1016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
force-pushed
the
brandur-shared-reduced-batch
branch
from
3cb547c to
5c69b13
Compare
This one continues #1013 by bringing reduced batch size circuit breakers to all other client maintenance services (previously it was only in `JobScheduler`). We extract some common constants and a couple helpers into `riversharedmaintenance`, then invoke that from each service. `riversharedmaintenance` is used so that the logic can potentially be shared outside the main River project as well. `circuitbreaker` has been moved from an internal package to `rivershared` for the same reason.
brandur
force-pushed
the
brandur-shared-reduced-batch
branch
from
5c69b13 to
db6a1b8
Compare
|
@bgentry This one requires another |
bgentry
approved these changes
Aug 16, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one continues #1013 by bringing reduced batch size circuit breakers
to all other client maintenance services (previously it was only in
JobScheduler). We extract some common constants and a couple helpersinto
riversharedmaintenance, then invoke that from each service.riversharedmaintenanceis used so that the logic can potentially beshared outside the main River project as well.
circuitbreakerhas beenmoved from an internal package to
riversharedfor the same reason.