remove unsafe casts and non-null assertions #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2025
|
@evelant many thanks for this PR! Hope this will get merged soon |
|
@evelant +1 thanks from me. I am experiencing hard crashes on android as well. Hope team can get to this soon. |
…ors to avoid crashes
|
Has this been pushed because I still manage to see the issue in "rive-react-native": "^9.6.1", |
|
@salmantln as you are posting this comment on an open PR, you can reasonably guess it has not been merged 😀 |
Contributor
|
@mfazekas I know we recently landed some changes for casts. Can you take a look at this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed all of the unsafe casts and non-null assertions that were causing crashes. Replaced them with error logging. Rive should no longer hard crash apps due to simple issues like being unmounted when an event fires.