Skip to content

Conversation

shkoo
Copy link
Contributor

@shkoo shkoo commented Aug 20, 2024

No description provided.

@shkoo shkoo marked this pull request as ready for review August 20, 2024 19:08
@pdg744
Copy link
Contributor

pdg744 commented Aug 20, 2024

oooo nice!

i haven't used digraph before -- is this the right tooling to be able to view the diagram? we've used mermaid elsewhere which at first glance seems to make it a bit easier to see the rendered diagram.

@pdg744
Copy link
Contributor

pdg744 commented Aug 20, 2024

i looked for a VS code extension and found TS prop dag, but i haven't been able to render the diagram using that tool.

@shkoo
Copy link
Contributor Author

shkoo commented Aug 20, 2024

i haven't used digraph before -- is this the right tooling to be able to view the diagram? we've used mermaid elsewhere which at first glance seems to make it a bit easier to see the rendered diagram.

The package is graphviz, specifically the dot layout. I'll update the comments to include that reference.

It looks like there are a couple of online graphviz sites like https://dreampuf.github.io/GraphvizOnline/ but they don't support some of the newer directives I'm using, so I fixed those too.

Yeah, I found mermaid which lets you embed directly in github markdown and tried to port this over, but it really doesn't quite have the same flexability as graphviz.

@shkoo shkoo merged commit bf135f5 into main Aug 20, 2024
7 checks passed
@shkoo shkoo deleted the nils/infra-dot branch August 20, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants