Skip to content

fix: blank screen when unknown alert message #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2024
Merged

fix: blank screen when unknown alert message #934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84adbad
fix: blank screen when unkonw alert message
embbnux Dec 16, 2024
c46fc48
chore: use ubuntu 22.04
embbnux Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on: [push, pull_request]

jobs:
test:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
strategy:
matrix:
node-version: [20.x]
Expand Down
5 changes: 5 additions & 0 deletions src/components/NotificationPanel/NotificationItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,11 @@ export const NotificationItem: FunctionComponent<NewNotificationItemProps> = mem
}),
[second],
);

// TODO: fix in widgets lib for blank screen in unknown alert message
if (Message === null || Message === undefined) {
return null;
}
return (
<div className={styles.container}>
{backdrop && (
Expand Down