Wip/ritesh/resilient stripper #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assumption that the signature file is well crafted is wrong. Over time, there have been numerous reports from many derivatives, that add many extra bits to the output. Obviously, apt never guaranteed a machine readable format for its output. With this change, we are being more resilient in dealing with each line in the signature file. Things like malforned file (cdrom lines - historical ones) or empty new lines should all be handled. apt-offline should treat the signature file dumb and very carefully and resiliently parse the content. Closes: #214
|
This is failing in the tests, as in exception are thrown for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be more resilient when parsing the signature file