Corrected pt language codes to BCP 47 format. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should now be parsable when thrown into a language tag parser.
I looked at the other half of your lib code and found more. Burmese is not linked...
And flagged the unimplemented Burmese language.
Author
|
man I am so not good at the githubs. Will get better. |
Owner
|
Thank you for taking the time to do this :) The BCP-47 updates are a good idea but does this change break backward compatibility with code that may be using this library already? I'm tempted to simply merge this update and see if there is any pushback from any developers on this change. On the other hand, it might make sense to maintain both "pt_BR" and "pt-BR" in the code. I will await your reply before merging the BCP47 changes. |
This was referenced Jun 14, 2013
Owner
|
Language support was added in 865b170. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should now be parsable when thrown into a language tag parser.