improve performance for large files #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `buf = Buffer.concat([buf, data]);` on the data event copies the data in a new larger buffer everytime. Instead, store the intermediate small buffers in an array and concat only at the end.
4 similar comments
Owner
|
Beautiful. Amazing increase in performance! Thank you very much :) |
Closed
|
Wow. This is a huge difference. Thanks @targos ! |
This was referenced Nov 18, 2019
Open
[Snyk(Unlimited)] Upgrade express-fileupload from 0.0.5 to 0.4.0
snyk-fixtures/js-nested-manifest#24
Open
Open
Open
[Snyk(Unlimited)] Upgrade express-fileupload from 0.0.5 to 0.4.0
snyk-fixtures/js-nested-manifest#35
Open
[Snyk(Unlimited)] Upgrade express-fileupload from 0.0.5 to 0.4.0
snyk-fixtures/js-nested-manifest#47
Open
Open
Open
[Snyk(Unlimited)] Upgrade express-fileupload from 0.0.5 to 0.4.0
snyk-fixtures/js-nested-manifest#58
Open
Open
Open
[Snyk(Unlimited)] Upgrade express-fileupload from 0.0.5 to 0.4.0
snyk-fixtures/js-nested-manifest#69
Open
[Snyk(Unlimited)] Upgrade express-fileupload from 0.0.5 to 0.4.0
snyk-fixtures/js-nested-manifest#80
Open
Open
Open
This was referenced Apr 15, 2020
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
buf = Buffer.concat([buf, data]);on the data event copies thedata in a new larger buffer everytime. Instead, store the intermediate
small buffers in an array and concat only at the end.
Test with a 117MB file: