Skip to content

Permit JS booleans to be bound to queries, as integer 0/1 values #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2025
Merged

Permit JS booleans to be bound to queries, as integer 0/1 values #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0961cd5
Permit boolean values to be bound to statements, as 0/1
grantcox May 3, 2025
032ccb2
Add test for boolean binding
grantcox May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/sqlite-api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ export function Factory(Module) {
}
case 'string':
return sqlite3.bind_text(stmt, i, value);
case "boolean":
return sqlite3.bind_int(stmt, i, value ? 1 : 0);
default:
if (value instanceof Uint8Array || Array.isArray(value)) {
return sqlite3.bind_blob(stmt, i, value);
Expand Down
21 changes: 21 additions & 0 deletions test/api_statements.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,27 @@ export function api_statements(context) {
}
});

it('should bind boolean', async function() {
let rc;
const sql = 'SELECT ?';
const storeValue = true;
const expectedRetrievedValue = 1;

for await (const stmt of i(sqlite3.statements(db, sql))) {
// Comlink intercepts the 'bind' property so use an alias.
rc = await sqlite3.bind$(stmt, 1, storeValue);
expect(rc).toEqual(SQLite.SQLITE_OK);

while ((rc = await sqlite3.step(stmt)) !== SQLite.SQLITE_DONE) {
expect(rc).toEqual(SQLite.SQLITE_ROW);

expect(await sqlite3.column_count(stmt)).toEqual(1);
expect(await sqlite3.column_type(stmt, 0)).toEqual(SQLite.SQLITE_INTEGER);
expect(await sqlite3.column_int(stmt, 0)).toEqual(expectedRetrievedValue);
}
}
});
Comment on lines +241 to +260
Copy link

@gemini-code-assist gemini-code-assist bot May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider adding a test case with storeValue set to false to ensure that false boolean values are correctly bound as 0.

Suggested change
it('should bind boolean', async function() {
let rc;
const sql = 'SELECT ?';
const storeValue = true;
const expectedRetrievedValue = 1;
for await (const stmt of i(sqlite3.statements(db, sql))) {
// Comlink intercepts the 'bind' property so use an alias.
rc = await sqlite3.bind$(stmt, 1, storeValue);
expect(rc).toEqual(SQLite.SQLITE_OK);
while ((rc = await sqlite3.step(stmt)) !== SQLite.SQLITE_DONE) {
expect(rc).toEqual(SQLite.SQLITE_ROW);
expect(await sqlite3.column_count(stmt)).toEqual(1);
expect(await sqlite3.column_type(stmt, 0)).toEqual(SQLite.SQLITE_INTEGER);
expect(await sqlite3.column_int(stmt, 0)).toEqual(expectedRetrievedValue);
}
}
});
it('should bind boolean false', async function() {
let rc;
const sql = 'SELECT ?';
const storeValue = false;
const expectedRetrievedValue = 0;
for await (const stmt of i(sqlite3.statements(db, sql))) {
// Comlink intercepts the 'bind' property so use an alias.
rc = await sqlite3.bind$(stmt, 1, storeValue);
expect(rc).toEqual(SQLite.SQLITE_OK);
while ((rc = await sqlite3.step(stmt)) !== SQLite.SQLITE_DONE) {
expect(rc).toEqual(SQLite.SQLITE_ROW);
expect(await sqlite3.column_count(stmt)).toEqual(1);
expect(await sqlite3.column_type(stmt, 0)).toEqual(SQLite.SQLITE_INTEGER);
expect(await sqlite3.column_int(stmt, 0)).toEqual(expectedRetrievedValue);
}
}
});


it('should bind collection array', async function() {
let rc;
const sql = 'VALUES (?, ?, ?, ?, ?)';
Expand Down
Loading