Build with v2 extensions #833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Change is good but please add the text to the commit message:
|
Enables older CPUs (2008-2013) to take advantage of certain hardware accelerators. Closes #828
Owner
|
Thanks! |
rfjakob
added a commit
that referenced
this pull request
Apr 13, 2025
As seen in #908, there are users still running x86-64-v1 cpus. They get This program can only be run on AMD64 processors with v2 microarchitecture support. and cannot read their encrypted files. Build for AMD64v1 again an accept the XChaCha20 performance hit for for some cpus ( golang/go#67240 ). This reverts commit f5007b2. Related: #828 #833 apptainer/apptainer#2873 golang/go#67240
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables older CPUs (2008-2013) to take advantage of certain hardware accelerators.
Closes #828