fix: upgrade to refractor 5.0.0 #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This constitutes a breaking change given the new refractor dependency major version, so I'll do some other changes while I'm at it and publish a new version soon - give me a few! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This is a first stab at trying to upgrade refractor to 5.0.0 so that we keep the same version everywhere (and don't need to upgrade anytime soon).
Part of larger work here and here (both wips)
Running the tests locally everything passed.
The dev server seems to be ok
But also, I don't have a whole lot of context about this plugin. Hopefully these make sense 🙏