Merge mono #21
Open
Merge mono #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: oss-fuzz:11040 Because we're sampling, the offset ends up the same as the width. Back up to the left enough to fit the bytes we will write. Change-Id: Ie476a0191b66c2322446b9c0922f630d6e971645 Reviewed-on: https://skia-review.googlesource.com/c/164262 Commit-Queue: Leon Scroggins <[email protected]> Commit-Queue: Mike Klein <[email protected]> Auto-Submit: Leon Scroggins <[email protected]> Reviewed-by: Mike Klein <[email protected]>
Bug: oss-fuzz:11114 fSrcOffsetUnits is where we start sampling from the image. It is computed as (sampleX / 2) * fSrcBPP (ignoring fSrcOffset, which is 0 for a GIF with a subset frame). sampleX will be no wider than the full image, and we divide it by two to sample points evenly spread through the image. But for a subset frame, we need to use a different sampling rate to ensure that the sampled points are within the width of the frame. Change-Id: I4a313db096fbaea7d869927a9da5df9beb9f6706 Reviewed-on: https://skia-review.googlesource.com/c/165500 Reviewed-by: Mike Klein <[email protected]> Commit-Queue: Leon Scroggins <[email protected]>
* Add SkColor4f for SkPixmap * Add the SkShader variants
Et7f3
force-pushed
the
merge-mono
branch
5 times, most recently
from
6086608 to
b8965f4
Compare
Et7f3
force-pushed
the
merge-mono
branch
6 times, most recently
from
9929c1b to
265d00e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersede #20