respect AWS_DEFAULT_REGION env var #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasjansson
force-pushed
the
configurable-s3-region
branch
from
b7f84f1 to
319a996
Compare
|
Could this just use the standard |
andreasjansson
force-pushed
the
configurable-s3-region
branch
from
319a996 to
cf5b709
Compare
Signed-off-by: Andreas Jansson <[email protected]>
andreasjansson
force-pushed
the
configurable-s3-region
branch
from
cf5b709 to
b39327b
Compare
andreasjansson
changed the title
|
@bfirsh yes good point! updated |
bfirsh
approved these changes
Mar 9, 2021
There was a problem hiding this comment.
A couple of things:
- S3 regions can also be set in the configuration file, and however else S3's standard discovery process works, so there is probably some logic in the S3 Go library that determines the region that should be used/reimplemented here.
- Maybe needs documenting? Or if it's using the built-in behavior, then perhaps it's implied.
Either way this is a lot better than nothing, so let's run with this. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets the user override the hardcoded s3 region (currently
us-east-1).