Skip to content

Conversation

andreasjansson
Copy link
Member

Signed-off-by: Andreas Jansson [email protected]

Copy link
Member

@bfirsh bfirsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure what is being fixed here -- the implementation seems to imply this is about fixing the case where just a file is passed to path and not a directory, but the PR title seems to imply this is fixing the case where a path is not passed to init().

I'm guessing that you thought the issue was not passing experiment path, but turns out that because experiment path was not being passed, but the problem was that it was just a single file? So in other words, experiment = replicate.init(path="foo.txt"); experiment.checkpoint(metrics={"foo": "bar"}) would cause same issue.

It'd be useful to get more detail with bug fixes like this, because it's quite hard to review without context.

Either way, I'm guessing you are testing and fixing the right thing here, so I'll trust you! XD

@bfirsh bfirsh merged commit 202aa57 into replicate:main Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants