Add underscore prefix to Experiment save and validate methods (#64) #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfirsh
requested changes
Mar 6, 2021
python/keepsake/pl_callback.py
Outdated
|
|
||
| opener = urllib.request.build_opener() | ||
| opener.addheaders = [("User-agent", "Mozilla/5.0")] | ||
| urllib.request.install_opener(opener) |
There was a problem hiding this comment.
We probably shouldn't monkey-patch urllib in code that's imported by users. If this is to fix a test, maybe it could go in the test code? That way it wouldn't affect users' programs.
There was a problem hiding this comment.
Yeah my bad! I though I put that block of code in test_pl_callback.py file not in pl_callback.py. It should be fixed now.
Signed-off-by: Gabriel Martín Blázquez <[email protected]>
|
I've fixed tests upstream so done a rebase... will merge when tests pass :) |
bfirsh
approved these changes
Mar 8, 2021
|
Thanks so much @gabrielmbmb! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the class
Experimentmethodssaveandvalidateto_saveand_validateas pointed out in #64.