Skip to content

Ignore files within a .git directory #2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Ignore files within a .git directory #2087

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac61c17
Ignore files within a .git directory
8W9aG Dec 9, 2024
34000e9
Check for the .git directory explicitly
8W9aG Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/weights/weights.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ func FindWeights(fw FileWalker) ([]string, []string, error) {
if info.IsDir() {
return nil
}
if isGitFile(path) {
return nil
}
if isCodeFile(path) {
codeFiles = append(codeFiles, path)
return nil
Expand Down Expand Up @@ -97,6 +100,10 @@ func isCodeFile(path string) bool {
return ext == ".py" || ext == ".ipynb"
}

func isGitFile(path string) bool {
return strings.Contains(path, ".git")
}

// filterDirsContainingCode filters out directories that contain code files.
// If a dir is a prefix for any given codeFiles, it will be filtered out.
func filterDirsContainingCode(dirs []string, codeFiles []string) []string {
Expand Down
16 changes: 16 additions & 0 deletions pkg/weights/weights_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,3 +160,19 @@ func TestSubDirMerge(t *testing.T) {
require.Empty(t, rootFiles)
require.Equal(t, []string{"models"}, dirs)
}

// Test case for ignoring files within a .git directory
func TestIgnoreGitFiles(t *testing.T) {
mockFileWalker := func(root string, walkFn filepath.WalkFunc) error {
sizes := []int64{sizeThreshold, sizeThreshold, 1024}
for i, path := range []string{".git/root-large", "root-large", "predict.py"} {
walkFn(path, mockFileInfo{size: sizes[i]}, nil)
}
return nil
}

dirs, rootFiles, err := FindWeights(mockFileWalker)
require.NoError(t, err)
require.Equal(t, []string{"root-large"}, rootFiles)
require.Empty(t, dirs)
}
Loading