don't block logs during iterators by fixing the lock #1802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we're currently holding the lock the whole time an iterator is running; it needs to be held separately for each send. instead of doing a bunch of indents, just factor out the locked send into a separate class although the lock isn't actually shared between processes and the more lightweight threading.Lock can be used, that means it has to be created in run() rather than __init__
technillogue
force-pushed
the
syl/fix-events-lock
branch
from
341bc68 to
5161afa
Compare
nickstenning
approved these changes
Jul 15, 2024
mattt
reviewed
Jul 15, 2024
mattt
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we're currently holding the lock the whole time an iterator is running; it needs to be held separately for each send. instead of doing a bunch of indents, just factor out the locked send into a separate class
although the lock isn't actually shared between processes and the more lightweight threading.Lock could be used, that means it has to be created in run() rather than
__init__