Skip to content

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Aug 7, 2025

Description

Fixed an issue where secure site screens would break in demo

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-3435

Showcase (Optional)

demo-auth-signing

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

linear bot commented Aug 7, 2025

Copy link

changeset-bot bot commented Aug 7, 2025

🦋 Changeset detected

Latest commit: b1db671

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@reown/appkit-controllers Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit Patch
@reown/appkit-ui Patch
pay-test-exchange Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-testing Patch
@reown/appkit-universal-connector Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@magiziz magiziz changed the title fix: secure site screens breaking in demo fix: secure site screens breaks in demo Aug 7, 2025
Copy link

vercel bot commented Aug 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2025 2:13pm
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2025 2:13pm
appkit-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2025 2:13pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2025 2:13pm
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored (Inspect) Aug 7, 2025 2:13pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Aug 7, 2025 2:13pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Aug 7, 2025 2:13pm
appkit-ethers5-bera ⬜️ Ignored (Inspect) Aug 7, 2025 2:13pm
appkit-nansen-demo ⬜️ Ignored (Inspect) Aug 7, 2025 2:13pm
appkit-vue-solana ⬜️ Ignored (Inspect) Aug 7, 2025 2:13pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Aug 7, 2025 2:13pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Aug 7, 2025 2:13pm
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Aug 7, 2025 2:13pm
vue-wagmi-example ⬜️ Ignored (Inspect) Aug 7, 2025 2:13pm

@magiziz magiziz changed the title fix: secure site screens breaks in demo fix: secure site screens break in demo Aug 7, 2025
@magiziz magiziz changed the title fix: secure site screens break in demo fix: secure site screens breaks in demo Aug 7, 2025
cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Aug 7, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.93% 32128 / 41223
🔵 Statements 77.93% 32128 / 41223
🔵 Functions 69.71% 2661 / 3817
🔵 Branches 84.78% 6831 / 8057
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/scaffold-ui/src/views/w3m-approve-transaction-view/index.ts 85.14% 100% 75% 85.14% 39-41, 44-48, 55-58, 107-109
Generated in workflow #14088 for commit b1db671 by the Vitest Coverage Report Action

Merged via the queue into main with commit 2bccf2a Aug 8, 2025
59 of 79 checks passed
@tomiir tomiir deleted the fix/embedded-secure-site branch August 8, 2025 08:15
This was referenced Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants