-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Closed
Labels
Bug ExternalBug Raised by CustomerBug Raised by Customer
Description
Link to minimal reproducible example
https://stackblitz.com/edit/github-g1lym3j3
Steps to Reproduce
Update package.json to v1.7.17
"@reown/appkit": "^1.7.17",
"@reown/appkit-adapter-ethers": "^1.7.17",
"@reown/appkit-siwe": "^1.7.17",
Now we get an error that a node.js dependency is now required on the client build.
File: /project/node_modules/cipher-base/index.js:1:1
× Module not found: Can't resolve 'stream' in '/project/node_modules/cipher-base'
╭─[4:16]
2 │
3 │ var Buffer = require('safe-buffer').Buffer;
4 │ var Transform = require('stream').Transform;
· ───────────────────────────
5 │ var StringDecoder = require('string_decoder').StringDecoder;
6 │ var inherits = require('inherits');
╰────
@ ./node_modules/create-hash/browser.js
@ ./node_modules/bitcoinjs-message/index.js
@ ./node_modules/bip322-js/dist/Verifier.js
@ ./node_modules/bip322-js/dist/index.js
@ ./node_modules/@reown/appkit-siwx/dist/esm/src/verifiers/BIP122Verifier.js
@ ./node_modules/@reown/appkit-siwx/dist/esm/src/configs/DefaultSIWX.js
@ ./node_modules/@reown/appkit-siwx/dist/esm/src/configs/index.js
@ ./node_modules/@reown/appkit-siwx/dist/esm/src/ui/w3m-data-capture-otp-confirm-view/index.js
@ ./node_modules/@reown/appkit-siwx/dist/esm/exports/ui.js
@ ./node_modules/@reown/appkit/dist/esm/src/client/appkit.js
@ ./node_modules/@reown/appkit/dist/esm/exports/index.js
@ ./src/integrations/wallets/reown.js
@ ./src/app.vue.js?vue&type=script&setup=true&lang=js!=!builtin:swc-loader??clonedRuleSet-5.use[0]!./node_modules/vue-loader/dist/index.js??ruleSet[0].use[0]!./src/app.vue?vue&type=script&setup=true&lang=js
@ ./src/app.vue.js?vue&type=script&setup=true&lang=js!=!./node_modules/vue-loader/dist/index.js??ruleSet[0].use[0]!./src/app.vue?vue&type=script&setup=true&lang=js
@ ./src/app.vue
@ ./src/main.js
Error: "stream" is a built-in Node.js module and cannot be imported in client-side code.
Downgrading to v1.7.16, seems like a regression.
Summary
Updating to v1.7.17 gives a node.js 'stream' issue.
Downgrading to v1.7.16, doesn't have this issue.
List of related npm package versions
v1.7.17
Node.js Version
bun v1.2.20
Package Manager
bun v1.2.20
Metadata
Metadata
Assignees
Labels
Bug ExternalBug Raised by CustomerBug Raised by Customer