feat(github-actions): Support actions/setup-dotnet with:dotnet-version #37369

martincostello · 2025-08-07T14:04:40Z

Changes

Add support for extracting dotnet-version from actions/setup-dotnet in the GitHub Actions manager.

Context

Renovate does not currently support updating the value specified by dotnet-version with actions/setup-dotnet such as the below:

- uses: actions/setup-dotnet@v4
  with:
    dotnet-version: 8.0.x

These changes should light-up support based on the custom syntax for the .NET SDK version the action supports (which is not the same syntax global.json itself supports).

I'm not sure what the best name for the new versioning strategy should be as it seems specific to the actions/setup-dotnet action. For now I've called it dotnet-sdk and based it on nuget.

Examples

Example updates this PR should enable depending on configuration.

Major update for A

- dotnet-version: 8
+ dotnet-version: 9

Major update for A.x

- dotnet-version: 8.x
+ dotnet-version: 9.x

Major update for A.B

- dotnet-version: 8.0
+ dotnet-version: 9.0

Major update for A.B.x

- dotnet-version: 8.0.x
+ dotnet-version: 9.0.x

Major update for A.B.Cxx

- dotnet-version: 8.0.1xx
+ dotnet-version: 9.0.1xx

Minor update for A.B.Cxx

- dotnet-version: 8.0.1xx
+ dotnet-version: 8.0.4xx

Minor update for A.B.C

- dotnet-version: 8.0.100
+ dotnet-version: 8.0.413

Major update for A.B.C

- dotnet-version: 8.0.100
+ dotnet-version: 9.0.304

Pinning for minor A.B.x

- dotnet-version: 8.0.x
+ dotnet-version: 8.0.413

Minor update for two A.B.C values

 dotnet-version: | 
-    8.0.100
-    9.0.100
+    8.0.413
+    9.0.304

I'm not sure if the last example will work or not - I've updated the manager so that it correctly extracts multiple values, but whether they would be successfully applied to the YAML file is a different question. I couldn't immediately see where to add a test for that scenario.

Documentation

I have updated the documentation, or
~~No documentation update is required~~

How I've tested my work

I have verified these changes via:

~~Code inspection only, or~~
Newly added/modified unit tests, or
~~No unit tests but ran on a real repository, or~~
~~Both unit tests + ran on a real repository~~

martincostello · 2025-08-07T14:18:32Z

lib/modules/manager/github-actions/extract.ts

+                depName: action,
+                packageName: packageName ?? `actions/${action}-versions`,
+                versioning,
+                extractVersion: '^(?<version>\\d+\\.\\d+\\.\\d+)(-\\d+)?$', // Actions release tags are like 1.24.1-13667719799


This might not be correct, as it doesn't look like it would work for values with an x in.

astellingwerf · 2025-08-07T16:03:56Z

lib/modules/versioning/dotnet-sdk/types.ts

+  type: 'dotnet-sdk-floating-range';
+  major: number;
+  minor?: number | 'x';
+  patch?: number | 'x';


The example on line 16 does not match the type declared here

True - it's mainly being used as a way to round-trip the string into its parts and back again for the A.B.x case when floating is minor.

Line 16 will be 8 0 400 in memory for the floating: 'patch' case.

lib/modules/versioning/dotnet-sdk/version.ts

Add support for extracting `dotnet-version` from `actions/setup-dotnet` in the GitHub Actions manager.

Add some more test cases.

Fix typo in comment. Co-authored-by: Anne Stellingwerf <[email protected]>

Fix typo in comment.

Resolve ESLint warnings.

viceice

we usually don't review draft PR's

Copilot

Pull Request Overview

This PR adds support for extracting and updating dotnet-version values from the actions/setup-dotnet GitHub Action. It implements a new .NET SDK versioning strategy specifically designed to handle the custom version syntax that actions/setup-dotnet supports.

Creates a new dotnet-sdk versioning strategy with full support for .NET SDK version formats
Updates the GitHub Actions manager to extract dotnet-version values from actions/setup-dotnet
Fixes a spelling error in the existing nuget version module

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
lib/modules/versioning/nuget/version.ts	Fixes spelling error in comment
lib/modules/versioning/dotnet-sdk/*.ts	New dotnet-sdk versioning module with parser, range handling, and comparison logic
lib/modules/versioning/api.ts	Registers the new dotnet-sdk versioning strategy
lib/modules/manager/github-actions/extract.ts	Updates GitHub Actions manager to support dotnet-version extraction
lib/modules/manager/github-actions/extract.spec.ts	Adds comprehensive tests for dotnet-version extraction
lib/modules/manager/github-actions/readme.md	Updates documentation to mention dotnet support

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-03T10:45:24Z

lib/modules/versioning/dotnet-sdk/version.ts

+  const xPatch = x.patch ?? 100;
+  const yPatch = y.patch ?? 100;


The magic number 100 is used as a default patch value without explanation. This should be documented with a comment explaining why 100 is the default patch value for .NET SDK versioning, or extracted to a named constant.

Copilot · 2025-09-03T10:45:24Z

lib/modules/versioning/dotnet-sdk/version.ts

+export function versionToString(version: DotnetSdkVersion): string {
+  let res = `${version.major}`;
+
+  res += `.${version.minor ?? 0}`;


Inconsistent default values are used: 0 for minor but 100 for patch. These magic numbers should be extracted to named constants to make the relationship clear and ensure consistency across the codebase.

Copilot · 2025-09-03T10:45:24Z

lib/modules/versioning/dotnet-sdk/version.ts

+
+  res += `.${version.minor ?? 0}`;
+
+  res += `.${version.patch ?? 100}`;


Inconsistent default values are used: 0 for minor but 100 for patch. These magic numbers should be extracted to named constants to make the relationship clear and ensure consistency across the codebase.

Copilot · 2025-09-03T10:45:24Z

lib/modules/versioning/dotnet-sdk/range.ts

+    minor: minor === 'x' ? 0 : minor,
+    patch: patch === 'x' ? 100 : patch,


The magic number 100 appears again as the default patch value. This should use the same named constant referenced in the previous comment to maintain consistency.

Copilot · 2025-09-03T10:45:25Z

lib/modules/versioning/dotnet-sdk/range.ts

+  } else if (r.floating === 'minor') {
+    return v.major === r.major && (v.minor ?? 0) === (r.minor ?? 0);
+  } else {
+    const patch = r.patch === 'x' || !r.patch ? 100 : r.patch;


Another instance of the magic number 100. This reinforces the need for a named constant to represent the default .NET SDK patch value.

Copilot · 2025-09-03T10:45:25Z

lib/modules/versioning/dotnet-sdk/parser.ts

+  } = groups;
+
+  if (prerelease) {
+    res.prerelease = groups.prerelease as `${string}*`;


The type assertion as ${string}`` is incorrect. The prerelease value doesn't necessarily end with '' and this type assertion is misleading. It should be as string or the type should be corrected.

Suggested change

res.prerelease = groups.prerelease as `${string}*`;

res.prerelease = groups.prerelease as string;

Copilot · 2025-09-03T10:45:25Z

lib/modules/manager/github-actions/extract.ts

+          currentValue.split(newlineRegex).forEach((value) => {
+            if (value) {


[nitpick] The nested forEach loop with conditional push could be refactored using filter and map for better readability: currentValue.split(newlineRegex).filter(Boolean).map(value => ({ ... })).forEach(dep => deps.push(dep))

martincostello · 2025-09-03T10:47:57Z

I'm not 100% on exactly how to approach this, so feedback/guidance sought. Then I can deal with the Copilot review comments and any other feedback.

martincostello force-pushed the update-dotnet-version-for-setup-dotnet branch from 6282ca5 to 81406a7 Compare August 7, 2025 14:08

martincostello mentioned this pull request Aug 7, 2025

docs: Delocalize URLs #37370

Merged

6 tasks

martincostello commented Aug 7, 2025

View reviewed changes

astellingwerf reviewed Aug 7, 2025

View reviewed changes

martincostello force-pushed the update-dotnet-version-for-setup-dotnet branch 2 times, most recently from c061318 to fcf411a Compare August 12, 2025 11:28

martincostello and others added 4 commits August 20, 2025 11:57

feat(github-actions): Support actions/setup-dotnet with:dotnet-version

6d7c063

Add support for extracting `dotnet-version` from `actions/setup-dotnet` in the GitHub Actions manager.

feat(github-actions): More test cases

20b0fc8

Add some more test cases.

fix(github-actions): Fix typo

694cc13

Fix typo in comment. Co-authored-by: Anne Stellingwerf <[email protected]>

fix(nuget): Fix typo

94d5cda

Fix typo in comment.

martincostello force-pushed the update-dotnet-version-for-setup-dotnet branch from fcf411a to 94d5cda Compare August 20, 2025 10:57

martincostello added 2 commits August 20, 2025 12:03

fix: remove radix

3b0c0d6

Resolve ESLint warnings.

Merge branch 'main' into update-dotnet-version-for-setup-dotnet

e02a7be

viceice reviewed Sep 3, 2025

View reviewed changes

Merge branch 'main' into update-dotnet-version-for-setup-dotnet

fc988d1

martincostello marked this pull request as ready for review September 3, 2025 10:42

Copilot AI review requested due to automatic review settings September 3, 2025 10:42

Copilot AI reviewed Sep 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(github-actions): Support actions/setup-dotnet with:dotnet-version #37369

feat(github-actions): Support actions/setup-dotnet with:dotnet-version #37369

Uh oh!

martincostello commented Aug 7, 2025

Uh oh!

martincostello Aug 7, 2025

Uh oh!

astellingwerf Aug 7, 2025

Uh oh!

martincostello Aug 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

viceice left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 3, 2025

Uh oh!

Copilot AI Sep 3, 2025

Uh oh!

Copilot AI Sep 3, 2025

Uh oh!

Copilot AI Sep 3, 2025

Uh oh!

Copilot AI Sep 3, 2025

Uh oh!

Copilot AI Sep 3, 2025

Uh oh!

Copilot AI Sep 3, 2025

Uh oh!

martincostello commented Sep 3, 2025

Uh oh!

Uh oh!

		const xPatch = x.patch ?? 100;
		const yPatch = y.patch ?? 100;


		res += `.${version.minor ?? 0}`;

		res += `.${version.patch ?? 100}`;

		minor: minor === 'x' ? 0 : minor,
		patch: patch === 'x' ? 100 : patch,

	res.prerelease = groups.prerelease as `${string}*`;
	res.prerelease = groups.prerelease as string;

		currentValue.split(newlineRegex).forEach((value) => {
		if (value) {

feat(github-actions): Support actions/setup-dotnet with:dotnet-version #37369

Are you sure you want to change the base?

feat(github-actions): Support actions/setup-dotnet with:dotnet-version #37369

Uh oh!

Conversation

martincostello commented Aug 7, 2025

Changes

Context

Examples

Major update for A

Major update for A.x

Major update for A.B

Major update for A.B.x

Major update for A.B.Cxx

Minor update for A.B.Cxx

Minor update for A.B.C

Major update for A.B.C

Pinning for minor A.B.x

Minor update for two A.B.C values

Documentation

How I've tested my work

Uh oh!

martincostello Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

astellingwerf Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

martincostello Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

viceice left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

martincostello commented Sep 3, 2025

Uh oh!

Uh oh!

martincostello Aug 7, 2025 •

edited

Loading