Skip to content

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Feb 21, 2025

Reverts #34244

@rarkins rarkins enabled auto-merge February 21, 2025 18:28
@rarkins rarkins requested a review from viceice February 21, 2025 18:28
@rarkins
Copy link
Collaborator Author

rarkins commented Feb 21, 2025

@maxbrunet the original change causes an undesirable change of branch name

e.g. I saw a change from rarkins/nvm6#5 to rarkins/nvm6#7 in one of my test directories. Branch name changed from renovate/node-20.x to renovate/node.js

@maxbrunet
Copy link
Contributor

Yes, like the other groups, why is it undesirable?

@rarkins
Copy link
Collaborator Author

rarkins commented Feb 21, 2025

Because it's lost the major version part

@maxbrunet
Copy link
Contributor

So if we set branchTopic on this preset, that'd be acceptable?

"branchTopic": "node-{{{newMajor}}}{{#if separateMinorPatch}}{{#if isPatch}}.{{{newMinor}}}{{/if}}{{/if}}.x"

@rarkins
Copy link
Collaborator Author

rarkins commented Feb 21, 2025

Why does it need to be a group name if it's all the same depName?

@maxbrunet
Copy link
Contributor

maxbrunet commented Feb 21, 2025

It's not all the same depName, the package can have the Docker registry as prefix: /(?:^|/)node$/

@rarkins
Copy link
Collaborator Author

rarkins commented Feb 21, 2025

That can remain as packageName

@maxbrunet
Copy link
Contributor

maxbrunet commented Feb 21, 2025

hmm not sure what do you mean, let's say we have that (for all of these depName==packageName):

# Dockerfile
FROM node:22.14.0
FROM library/node:22.14.0
FROM docker.io/library/node:22.14.0
FROM public.ecr.aws/docker/library/node:22.14.0

And a .nvmrc

22.14.0

How would Renovate be able to group them?

@rarkins
Copy link
Collaborator Author

rarkins commented Feb 22, 2025

Yes if depName is "Node.js" for all

@rarkins rarkins added this pull request to the merge queue Feb 22, 2025
Merged via the queue into main with commit 77a86c1 Feb 22, 2025
39 checks passed
@rarkins rarkins deleted the revert-34244-fix/presets/actually-group-nodejs branch February 22, 2025 07:51
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.177.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants