-
Notifications
You must be signed in to change notification settings - Fork 2.7k
fix(presets): Revert "fix(presets): actually group Node.js packages" #34379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 904a52b.
@maxbrunet the original change causes an undesirable change of branch name e.g. I saw a change from rarkins/nvm6#5 to rarkins/nvm6#7 in one of my test directories. Branch name changed from |
Yes, like the other groups, why is it undesirable? |
Because it's lost the major version part |
So if we set "branchTopic": "node-{{{newMajor}}}{{#if separateMinorPatch}}{{#if isPatch}}.{{{newMinor}}}{{/if}}{{/if}}.x" |
Why does it need to be a group name if it's all the same depName? |
It's not all the same |
That can remain as packageName |
hmm not sure what do you mean, let's say we have that (for all of these # Dockerfile
FROM node:22.14.0
FROM library/node:22.14.0
FROM docker.io/library/node:22.14.0
FROM public.ecr.aws/docker/library/node:22.14.0 And a
How would Renovate be able to group them? |
Yes if depName is "Node.js" for all |
🎉 This PR is included in version 39.177.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Reverts #34244