-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
feat: add vite preview support
#14507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 1707040 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
The newly released [React Router 7.11.0](remix-run/react-router#14507) introduced vite preview support(remix-run/react-router#14507). This change has a bug that affects SPA mode (ssr: false). When building in SPA mode, React Router correctly builds the server bundle (build/server/index.js) and then removes it with the message "Removing the server build... due to ssr:false". The new vite preview implementation 7.11.0 doesn't account for this removal and attempts to import the deleted `build/server/index.js` file when starting the preview server, causing the `Cannot find module '/build/server/index.js'` issue.
The newly released [React Router 7.11.0](remix-run/react-router#14507) introduced vite preview support(remix-run/react-router#14507). This change has a bug that affects SPA mode (`ssr: false`). When building in SPA mode, React Router correctly builds the server bundle (`build/server/index.js`) and then removes it with the message `Removing the server build... due to ssr:false`. The new vite preview implementation doesn't account for this removal and attempts to import the deleted `build/server/index.js` file when starting the preview server, causing: > Cannot find module '/build/server/index.js' Closes #18549 (added automatically)
No description provided.