Default to plaintext code instead of empty codeblock #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When autohighlighting and highlightjs is unable to detect the language Fixes #12
|
That definitely sounds like a bug! Do you remember how to reproduce it? As it is a bug, it would be nice to have a test so it doesn’t happen again! |
|
This link shows the bug https://codesandbox.io/s/rehype-highlight-subset-bug-o1dnx?file=/src/index.js . Screenshot in #12 If you meant that it is a bug in highlightjs, I think that might be intended behaviour. |
|
I can’t reproduce this locally, so it does seem like something changed in lowlight/highlight.js |
wooorm
added
⛵️ status/released
🐛 type/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When autohighlighting and highlightjs is unable to detect the language
Fixes #12