spm: ldk-node 0.4.0

[reez]

Description

https://github.com/lightningdevkit/ldk-node/releases/tag/v0.4.0

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

• I've signed all my commits
• I have formatted my code with swift-format per .swift-format file

New Features:

• I've added tests for the new feature
• I've added docs for the new feature

Bugfixes:

• This pull request breaks the existing API
• I've added tests to reproduce the issue which are now passing
• I'm linking the issue being fixed by this PR

Summary by CodeRabbit

• New Features

  • Introduced new remote package dependency for ldk-node, enhancing integration capabilities.
  • Updated error handling to manage invalid node aliases more effectively.

• Improvements

  • Enhanced safety in event descriptions by improving optional value handling.
  • Streamlined API for opening channels and configuring the Esplora server.

• Bug Fixes

  • Removed outdated error case for message signing failures.

• Refactor

  • Renamed properties and methods for clarity, including changing isPublic to isAnnounced.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several modifications across various files in the LDKNodeMonday project. Key changes include downgrading the objectVersion in the project file, updating package references to utilize a remote Swift package, and enhancing the safety of optional value handling in the Event extension. Additionally, method signatures in LightningNodeService.swift have been simplified, and error handling has been refined in LightningServiceError.swift. Lastly, a property name in ChannelDetailView.swift has been updated to better reflect its purpose.

Changes

File	Change Summary
LDKNodeMonday.xcodeproj/project.pbxproj	- objectVersion downgraded from 60 to 56 - Added LDKNode framework in PBXBuildFile - Removed local Swift package reference, added remote reference for ldk-node
LDKNodeMonday.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved	- Updated originHash - Added new dependency for ldk-node with details on identity, kind, location, and state
LDKNodeMonday/Extensions/Event+Extensions.swift	- Updated description property for Event to enhance safety with optional values
LDKNodeMonday/Service/Lightning Service/LightningNodeService.swift	- Renamed method connectOpenChannel to openChannel - Replaced setEsploraServer with setChainSourceEsplora accepting a nil config
LDKNodeMonday/Service/Lightning Service/LightningServiceError.swift	- Removed case .MessageSigningFailed - Added case .InvalidNodeAlias
LDKNodeMonday/View/Profile/Channel/ChannelDetailView.swift	- Renamed property isPublic to isAnnounced

Possibly related PRs

• spm: ldk-node v0.3.0 #104: This PR updates the objectVersion from 60 to 56 in the LDKNodeMonday.xcodeproj/project.pbxproj file, which directly relates to the changes made in the main PR that also involve downgrading the objectVersion from 60 to 56.
• spm: local build ldk-node commit 246775d #90: This PR also modifies the LDKNodeMonday.xcodeproj/project.pbxproj file, including changes to the objectVersion and references to the LDKNode framework, which are relevant to the modifications in the main PR.
• spm: local build ldk-node main commit 9990e51 #95: Changes in this PR to the LightningNodeService.swift file include modifications to method signatures, which may relate to the overall restructuring of the service in the main PR, although the connection is less direct.
• bip21 #110: This PR includes significant modifications to the LDKNodeMonday.xcodeproj/project.pbxproj file, including changes to the objectVersion and references to ldk-node, which are relevant to the changes in the main PR.

🐇 In the code we hop and play,
With versions changed, we clear the way.
From local paths to remote sights,
Our channels open, reaching new heights.
With safety first, we code with cheer,
In the world of nodes, we have no fear! 🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.