feat(ui): Keep cursors in their respective workflows and Hook Refactor [FLOW-FE-267] #1418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Cloud Run Preview Deployed |
There was a problem hiding this comment.
Pull Request Overview
This PR implements workflow-specific cursor visibility, ensuring that user cursors are only displayed to collaborators who are working within the same workflow. The changes track which workflow each user is currently viewing and their open workflows through the awareness system.
- Added workflow tracking fields to user awareness state
- Implemented cursor filtering based on current workflow context
- Added spotlight user workflow synchronization functionality
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/src/types/user.ts | Extended AwarenessUser type with workflow tracking fields |
| ui/src/lib/yjs/useWorkflowTabs.ts | Exposed openWorkflowIds for awareness updates |
| ui/src/features/Editor/index.tsx | Passed currentWorkflowId to Canvas component |
| ui/src/features/Editor/hooks.ts | Added workflow state synchronization and spotlight user workflow handling |
| ui/src/features/Canvas/index.tsx | Added currentWorkflowId prop and conditional MultiCursor rendering |
| ui/src/features/Canvas/components/MultiCursor/index.tsx | Implemented workflow-based cursor filtering |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
billcookie
changed the title
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…arth-flow into ui/awareness-subworkflow-fix
KaWaite
approved these changes
Sep 16, 2025
shunski
pushed a commit
that referenced
this pull request
Sep 16, 2025
…r [FLOW-FE-267] (#1418) * feat(ui): Keep cursors in their respective workflows * fix(ui): prettier check ran * feat(ui): add openWorkflowIds to user state and update workflow handling logic * feat(ui): implement useSpotlightUser hook for managing spotlight user workflows * feat(ui): refactor spotlight user handling and add awareness cursor hook * fix(ui): removed unnecessary conditional * fix(ui): type issue for handlePaneMouseMove * fix(ui): only update awareness when multiple users * fix(ui): remove console logs * fix(ui): cursor z-index from 1000 to 2000 to fix batch node collision issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements workflow-specific cursor visibility, ensuring that user cursors are only displayed to collaborators who are working within the same workflow. The changes track which workflow each user is currently viewing and their open workflows through the awareness system.
What I've done
What I haven't done
How I tested
Screenshot
Which point I want you to review particularly
Memo