fix(tui): validate spinner.characters (≥2) and frameInterval (>0); add first tests #12088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you! |
Tobbe
approved these changes
Sep 13, 2025
Tobbe
added
changesets-ok
Tobbe
added a commit
to cedarjs/cedar
that referenced
this pull request
Sep 13, 2025
…d first tests redwoodjs/graphql#12088 Co-authored-by: Tobbe Lundberg <[email protected]>
Tobbe
added a commit
to cedarjs/cedar
that referenced
this pull request
Sep 19, 2025
…d first tests redwoodjs/graphql#12088 Co-authored-by: Tobbe Lundberg <[email protected]>
Tobbe
added a commit
that referenced
this pull request
Oct 16, 2025
…d first tests (#12088) Co-authored-by: Tobbe Lundberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements two small TODOs in packages/tui/src/index.ts:
spinner.charactersto be an array with ≥2 entries.frameIntervalto be a number > 0.Adds the first tests for the TUI package in
packages/tui/src/index.test.ts(valid + invalid cases). No behavior changes for valid inputs.