feat(dbAuth): Lax SameSite cookie policy #11889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
added a commit
that referenced
this pull request
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the
SameSitecookie policy toLaxallows users to be immediately authenticated when arriving from external domains.This is also what Djang and Ruby on Rails has by default.
Here are the Django docs saying it's Lax by default:
https://docs.djangoproject.com/en/5.1/ref/settings/#session-cookie-samesite
Here's the Rails test that asserts that it's Lax by default:
https://github.com/rails/rails/blob/da32425a0864f6da7bdd2a8d3a43027fbfb2a504/railties/test/application/configuration_test.rb#L3352