chore(repo): update all deps #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-mouland
force-pushed
the
chore/deps-latest
branch
from
b7b5dd0 to
41c8d96
Compare
|
Ah, yes, I'm generally not a fan of the TS-Lint recommend ruleset :) I'd suggest basing the linting rules off of whatever we currently have configured over in the Redux Toolkit repo. |
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 102 102
Branches 24 24
=========================================
Hits 102 102
|
markerikson
force-pushed
the
chore/deps-latest
branch
from
89e7ec9 to
851ae37
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #461 (comment)
I've gone with the approach of "get it working", by turning off the ts linting errors.
"get it working better" can be done after this is merged and people decide how they want to handle the rules like any's vs unknowns and explicit return types etc.
All tests + linting passed locally