Add DELREF and ACKED support to XADD #881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueian
requested changes
Jul 5, 2025
hack/cmds/commands.json
Outdated
| "command": "ACKED", | ||
| "type": "command", | ||
| "optional": true | ||
| }, |
Collaborator
There was a problem hiding this comment.
Hi @Ryan2327, they should be in one enum type. Please take a look at https://github.com/redis/rueidis/pull/882/files. Also, they should be put behind the LIMIT option.
rueian
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new DELREF and ACKED options for the XADD command.
commands.jsonto include DELREF and ACKEDgo generateto regenerate the buildergen_stream_test.goto validate builder behaviorPlease review.