Make optimistic version locking optional #856
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueian
reviewed
Jun 12, 2025
Comment on lines
+74
to
+75
| s.ver = &field{reflect.TypeOf(int64(0)), "", -1, false, true, false} | ||
| s.verless = true |
There was a problem hiding this comment.
I wonder if it is possible to just keep s.ver == nil?
There was a problem hiding this comment.
Definitely can do that, just would result in more LOC changed.
There was a problem hiding this comment.
@sgtsquiggs, maybe we should keep the current approach. Is this PR ready for merge?
There was a problem hiding this comment.
Hi @sgtsquiggs, could you help resolve the conflicts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make the
reids:",ver"tag optional. This PR will resolve #854.Usecase:
You are using
rueidis/omto keep a cache up-to-date, reading directly off a kafka queue. You do not want to deal with versioning your data in redis. You are always upserting.TODO: