Skip to content

Conversation

leibale
Copy link
Contributor

@leibale leibale commented Dec 11, 2022

Refactor PubSub
fix #2354 - Add support for sharded PubSub
fix #1968 - PUBSUB SHARDCHANNELS command
fix #2345 ref #2321 - PING in PubSub mode
fix #2302 - error listener note in the main README
Add minimizeConnections configuration for clusters

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2022

Codecov Report

Base: 95.85% // Head: 96.09% // Increases project coverage by +0.23% 🎉

Coverage data is based on head (8ea2123) compared to base (9dccd9a).
Patch coverage: 93.47% of modified lines in pull request are covered.

❗ Current head 8ea2123 differs from pull request most recent head d4bb5f3. Consider uploading reports for the commit d4bb5f3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2344      +/-   ##
==========================================
+ Coverage   95.85%   96.09%   +0.23%     
==========================================
  Files         449      452       +3     
  Lines        4224     4300      +76     
  Branches      471      472       +1     
==========================================
+ Hits         4049     4132      +83     
+ Misses        107      102       -5     
+ Partials       68       66       -2     
Impacted Files Coverage Δ
packages/client/lib/client/commands-queue.ts 88.76% <91.42%> (+5.86%) ⬆️
packages/client/lib/client/pub-sub.ts 91.96% <91.96%> (ø)
packages/client/lib/client/commands.ts 100.00% <100.00%> (ø)
packages/client/lib/client/index.ts 91.53% <100.00%> (+0.40%) ⬆️
packages/client/lib/cluster/commands.ts 100.00% <100.00%> (ø)
packages/client/lib/commands/PING.ts 100.00% <100.00%> (ø)
packages/client/lib/commands/PUBLISH.ts 100.00% <100.00%> (ø)
...ckages/client/lib/commands/PUBSUB_SHARDCHANNELS.ts 100.00% <100.00%> (ø)
packages/client/lib/commands/SPUBLISH.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leibale leibale closed this Jan 10, 2023
@leibale leibale deleted the sharded-pubusb branch January 10, 2023 01:04
@leibale
Copy link
Contributor Author

leibale commented Jan 10, 2023

#2373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants