-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Introduces test matrix based on Redis versions [8.0-M1, 7.4.1, 7.2.6, 6.2.16] #4015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
81 commits
Select commit
Hold shift + click to select a range
33f79ce
Introduces test matrix based on Redis versions [8.0-M1, 7.4.1, 7.2.6,…
ggivo 8c43145
Fix GeoXXX tests
ggivo 788f3cb
REDIS_VERSION env var for setting test container version
ggivo ed13876
Remove accidentally submitted conf directive
ggivo d076edc
Revert changes in integration action
ggivo 834a1b3
EnabledOnCommandRule get info only for requested command
ggivo 8543deb
Remove accidentally added SinceRedisVersion 7.0.0 for ControlCommands…
ggivo b0f1ac0
Found issue with CommandInfo command
ggivo 7ed5de2
Use SinceRedisVersion instead of "EnableOnCmmand" because of https://…
ggivo 4c999bb
Use SinceRedisVersion instead of "EnableOnCommand" because of https:/…
ggivo ea57770
switch default TEST_ENV_PROVIDER
ggivo 594c4da
Use CommandInfo for subcommand
sazzad16 cce4b19
Get Iterable from Map
sazzad16 b8e7c05
Use client-libs-test image based on redis-server-stack
ggivo 4bce8ad
Fix: command and subcommand are concatenated with a pipe
sazzad16 90335d1
Remove commented out code
ggivo 538e3c2
Revert "Use client-libs-test image based on redis-server-stack"
ggivo c008010
Use native redis TLS support
ggivo 303f152
Introduce forceRedisServerVersion into test
ggivo 73366a2
Fix accidently removed default for 6.2.16 version
ggivo 3e33d07
Generate .key from private.pem
ggivo 41aadde
add ::1 to expected local ip's in the test
ggivo 30cf4e1
add ::1 to expected local ip's in the test
ggivo a8f5e20
Switch ctest env setup default from 'local' to 'docker'
ggivo a1e05a5
Mark SSL & ACL test's since 7.0
ggivo 8e9f4b3
Mark SSL & ACL test's since 7.0
ggivo a2e77ca
Fix NPE in test clean up
ggivo 42a5531
Add how to bootstrap test env with Docker
ggivo ea7e2c3
Add make target to start containerised test env.
ggivo a5a9ca2
use dedicate .env file for 6.2.16
ggivo 109d3b6
Apply review comments
ggivo a8b48b4
re-enable commandInfoWithSubcommands()
ggivo 123d01d
re-enable commandInfoWithSubcommands()
ggivo d233a22
remove duplicated test
ggivo ff2a3b6
Code clean up
ggivo 4a22633
Update ControlCommandsTest.java
sazzad16 b6cee30
Apply suggestions from code review
ggivo ab91c93
Addressing review comments
ggivo 5d60f37
Update src/test/java/redis/clients/jedis/commands/jedis/AllKindOfValu…
ggivo eab7696
Undo JedisCommandsTestBase.java formatting only changes
sazzad16 c7a123f
Apply suggestions from code review
sazzad16 58de742
Addressing review comments
ggivo 501cc80
Update src/test/java/redis/clients/jedis/commands/commandobjects/Comm…
ggivo 5eb177b
Update src/test/java/redis/clients/jedis/EndpointConfig.java
ggivo bf837ff
Fix compilation errors after rebase
ggivo 7bde644
rebase on master to accommodate "Add SslOptions #3980"
ggivo 9269e0e
fix
ggivo 33c7545
preserve logs on failure
ggivo b456013
fix
ggivo 9ee95fd
Fix tests
ggivo ad49109
Address review comments.
ggivo 10f7dc8
Apply suggestions from code review
ggivo f6689b4
Address review comments.
ggivo e9aaf8a
Apply suggestions from code review
ggivo 419350d
Update src/test/java/redis/clients/jedis/commands/jedis/ClusterComman…
ggivo 5a37acc
formating
ggivo 31f0b5f
formating
ggivo 96c8c61
Apply suggestions from code review
ggivo 9a7a061
undo formatting-only changes; reformat imports; etc
sazzad16 0aa6dca
undo formatting-only changes; reformat imports; etc
sazzad16 beb0ec5
undo formatting-only changes; reformat imports; etc
sazzad16 2523857
Attempt to address codescanning error
ggivo 32a1348
Fix GeoPipelineCommandsTest
ggivo 0f884c6
Fix SSLOptionsJedisClusterTest.testSSLWithoutPortMap
ggivo 5684066
Mark SSLJedisClusterTest to be executed on Redis 7.x+
ggivo 1b27308
Replaces "environment" with "certificateLocation" in EndpointConfig.
ggivo da8bd38
making private
sazzad16 bd0a353
undo some renames about Geo matcher
sazzad16 e106f0b
check member in GeoRadiusResponseMatcher
sazzad16 f33e418
rename static method in GeoRadiusResponseMatcher
sazzad16 dbb3f72
use 8.0-M02
sazzad16 8644777
remove repeated 8.0-M02 from docker compose default value
sazzad16 428585c
Use Redis CE for 8.x redis stack related tests
ggivo f3e0b7a
Revisit module tests to run on 7.2 and mark where needed required sin…
ggivo 122a58f
Fix in 7.4
ggivo c400da8
modify SearchWithParamsTest fixes
sazzad16 49dcf4d
Disable testing against 6.2.16 till module test's are migrated to sup…
ggivo 174b933
Merge branch 'master' into migrate_to_clients_test_image
sazzad16 bb5b434
Temporary disable restoreParams() tests because of regression in 8.0…
ggivo dd316bd
Try to print current surefire jvm settings
ggivo 71a30fd
Revert : Try to print current surefire jvm settings
ggivo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,124 @@ | ||
| --- | ||
|
|
||
| name: Build and Test using containerized environment | ||
|
|
||
| on: | ||
| push: | ||
| paths-ignore: | ||
| - 'docs/**' | ||
| - '**/*.md' | ||
| - '**/*.rst' | ||
| branches: | ||
| - master | ||
| - '[0-9].*' | ||
| pull_request: | ||
| branches: | ||
| - master | ||
| - '[0-9].*' | ||
| schedule: | ||
| - cron: '0 1 * * *' # nightly build | ||
| workflow_dispatch: | ||
| inputs: | ||
| specific_test: | ||
| description: 'Run specific test(s) (optional)' | ||
| required: false | ||
| default: '' | ||
| jobs: | ||
|
|
||
| build: | ||
| name: Build and Test | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| REDIS_ENV_WORK_DIR: ${{ github.workspace }}/redis-env-work | ||
| REDIS_ENV_CONF_DIR: ${{ github.workspace }}/src/test/resources/env | ||
| CLIENT_LIBS_IMAGE_PREFIX: "redislabs/client-libs-test" | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| redis_version: | ||
| - "8.0-M02" | ||
| - "7.4.1" | ||
| - "7.2.6" | ||
| # - "6.2.16" | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Set up publishing to maven central | ||
| uses: actions/setup-java@v2 | ||
| with: | ||
| java-version: '8' | ||
| distribution: 'temurin' | ||
| - name: System setup | ||
| run: | | ||
| sudo apt update | ||
| sudo apt install -y make | ||
| make compile-module | ||
| - name: Cache dependencies | ||
| uses: actions/cache@v2 | ||
| with: | ||
| path: | | ||
| ~/.m2/repository | ||
| /var/cache/apt | ||
| key: jedis-${{hashFiles('**/pom.xml')}} | ||
| # Set up Docker Compose environment | ||
| - name: Set up Docker Compose environment | ||
| run: | | ||
| mkdir -m 777 $REDIS_ENV_WORK_DIR | ||
| export REDIS_VERSION="${{ matrix.redis_version }}" | ||
| make start-test-env version=$REDIS_VERSION | ||
| - name: Maven offline | ||
| run: | | ||
| mvn -q dependency:go-offline | ||
| - name: Build docs | ||
| run: | | ||
| mvn javadoc:jar | ||
| # Run Tests | ||
| - name: Run Maven tests | ||
| run: | | ||
| export TEST_ENV_PROVIDER=docker | ||
| export TEST_WORK_FOLDER=$REDIS_ENV_WORK_DIR | ||
| echo $TEST_WORK_FOLDER | ||
| if [ -z "$TESTS" ]; then | ||
| mvn clean compile test | ||
| else | ||
| mvn -Dtest=$TESTS clean compile test | ||
| fi | ||
| env: | ||
| TESTS: ${{ github.event.inputs.specific_test || '' }} | ||
ggivo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - name: Publish Test Results | ||
| uses: EnricoMi/publish-unit-test-result-action@v2 | ||
| if: always() | ||
| with: | ||
| files: | | ||
| target/surefire-reports/**/*.xml | ||
| # Collect logs on failure | ||
| - name: Collect logs on failure | ||
| if: failure() # This runs only if the previous steps failed | ||
| run: | | ||
| echo "Collecting logs from $WORK_DIR..." | ||
| ls -la $REDIS_ENV_WORK_DIR | ||
| # Upload logs as artifacts | ||
| - name: Upload logs on failure | ||
| if: failure() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: redis-env-work-logs-${{ matrix.redis_version }} | ||
| path: ${{ env.REDIS_ENV_WORK_DIR }} | ||
| # Bring down the Docker Compose test environment | ||
| - name: Tear down Docker Compose environment | ||
| if: always() | ||
| run: | | ||
| docker compose $COMPOSE_ENV_FILES -f src/test/resources/env/docker-compose.yml down | ||
| continue-on-error: true | ||
| # Upload code coverage | ||
| - name: Upload coverage to Codecov | ||
| uses: codecov/codecov-action@v4 | ||
| with: | ||
| fail_ci_if_error: false | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| - name: Upload test results to Codecov | ||
| if: ${{ github.event_name == 'schedule' || (github.event_name == 'push') || github.event_name == 'workflow_dispatch'}} | ||
| uses: codecov/test-results-action@v1 | ||
| with: | ||
| fail_ci_if_error: false | ||
| files: ./target/surefire-reports/TEST* | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,9 @@ build/ | |
| bin/ | ||
| tags | ||
| .idea | ||
| .run | ||
| *.aof | ||
| *.rdb | ||
| redis-git | ||
| appendonlydir/ | ||
| .DS_Store | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.