-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat(cmd): Add CAS/CAD commands #3583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+1,769
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decided to move the *Get argument as a separate methods, since the response will be always the previous value, but in the case where the previous value is `OK` there result may be ambiguous.
|
I am considering changing the digest to uint64 to match https://github.com/zeebo/xxh3 and add documentation to suggest using https://github.com/zeebo/xxh3 for generating digests on the application level. |
6af5087 to
bdefae8
Compare
bdefae8 to
3a31338
Compare
ofekshenawa
reviewed
Nov 7, 2025
ofekshenawa
reviewed
Nov 7, 2025
ofekshenawa
approved these changes
Nov 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding CAS/CAD commands available in redis 8.4:
I did change the methods and added
*Getmethods for eachSetIF*method, since the responses mean different things (i.e. Set will return statusOKbut if it isset ... ifneq .. getit still can return OK if the previous value of the key wasOK. This way it is more clear, the returned commands are StatusCmd or StringCmd and they both mean different things (should) to the user.What is still a
StatusCmdthat can actually hold the previous value, is the return ofSetArgsif we haveGet=Truein the args. Any feedback on how to handle this better is welcome.