Skip to content

Fix FT.Search Limit argument and add CountOnly argument for limit 0 0 #3338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2025
Merged

Fix FT.Search Limit argument and add CountOnly argument for limit 0 0 #3338

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
639b45e
Fix Limit argument and add CountOnly argument
ofekshenawa Apr 7, 2025
5af10b9
Add test and Documentation
ofekshenawa Apr 14, 2025
974623f
Update search_commands.go
ndyakov Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions search_commands.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,7 @@ type FTSearchOptions struct {
SortByWithCount bool
LimitOffset int
Limit int
CountOnly bool
Params map[string]interface{}
DialectVersion int
}
Expand Down Expand Up @@ -1954,8 +1955,12 @@ func (c cmdable) FTSearchWithArgs(ctx context.Context, index string, query strin
args = append(args, "WITHCOUNT")
}
}
if options.LimitOffset >= 0 && options.Limit > 0 {
args = append(args, "LIMIT", options.LimitOffset, options.Limit)
if options.CountOnly {
args = append(args, "LIMIT", 0, 0)
} else {
if options.LimitOffset >= 0 && options.Limit > 0 || options.LimitOffset > 0 && options.Limit == 0 {
args = append(args, "LIMIT", options.LimitOffset, options.Limit)
}
}
if options.Params != nil {
args = append(args, "PARAMS", len(options.Params)*2)
Expand Down
Loading