Skip to content

Conversation

mickaelistria
Copy link
Contributor

No description provided.

@rgrunber
Copy link
Member

Nice. I'll give it a try. So basically this is a way for developers who may want to test in VS Code (or verify they aren't breaking VS Code) but they don't want to set NodeJS/NPM and perform that aspect of the build. This solution allows them to hijack an existing vsix, and just swap out JDT-LS.

Definitely a "user at your own risk" but it would reduce the barrier to entry for some.

Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me! Some good news. Everything I said about needing to clean up the configuration being stored in the globalStorage/ folder doesn't apply. We create the location in resolveConfiguration(context, configDir) but your code will never take that path, so we can leave the contents completely untouched and the user can go back to their normal setup when they remove the JDT_LS_PATH environment variable!

CONTRIBUTING.md Outdated
- Clear the workspace state: `$ rm -r /home/userId/.config/Code/User/workspaceStorage/0123456789abcdef01234567890abcdef/redhat.java/jdt_ws`
- Start VSCode with the `JDT_LS_PATH` environment variable set to the local copy of JDT-LS you want to try: `$ JDT_LS_PATH=/home/userId/git/eclipse.jdt.ls/org.eclipse.jdt.ls.product/target/products/languageServer.product/linux/gtk/x86_64 code`

Most other options such as `DEBUG_VSCODE_JAVA` are still usable with this approach.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'4' is just a typo here and can be removed I think.

@mickaelistria
Copy link
Contributor Author

@rgrunber all suggestions should have been addressed now.

@rgrunber rgrunber modified the milestone: End June 2023 Jun 15, 2023
@rgrunber rgrunber merged commit 9a0b66c into redhat-developer:master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants